-
Notifications
You must be signed in to change notification settings - Fork 981
[core] Trigger endpoint to allow clickhouse suggest merge uid. #7098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y-server into feature/ingestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces functionality to allow ClickHouse (or other plugins) to suggest which user ID should be the winner during user merge operations, rather than always using the default merge logic based on last session time.
Key Changes:
- Added a new plugin dispatch endpoint
/i/suggest_merged_uidthat allows plugins to influence merge decisions - Modified the merge flow to handle three scenarios: winner is old UID, winner is new UID (default), or winner is a completely different UID (double merge)
- Added
mergeOptionsparameter to themergeUserDatafunction to pass plugin suggestions through to merge handlers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| api/parts/mgmt/app_users.js | Core merge logic updated to dispatch to plugins for merge UID suggestions and handle the suggested winner UID in three different scenarios |
| plugins/times-of-day/tests.js | Added test to trigger mutation manager job after app reset to ensure proper cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.