Exercise both compressed and un-compressed PDF.write#34
Merged
liZe merged 1 commit intoCourtBouillon:mainfrom Feb 9, 2026
Merged
Exercise both compressed and un-compressed PDF.write#34liZe merged 1 commit intoCourtBouillon:mainfrom
PDF.write#34liZe merged 1 commit intoCourtBouillon:mainfrom
Conversation
Contributor
Author
|
I'm happy to submit more unit tests, but I'd rather not swamp you with requests, so please let me know if this is something you want. |
Depending on whether `PDF.write` is called with `compress` set to `True` or `False`, two almost distinct code paths are taken. Ensure we exercise both code paths.
jlaine
force-pushed
the
improve-test-coverage
branch
from
243f17b to
b8f239d
Compare
Member
|
Hi @jlaine!
Good idea, thanks a lot.
No problem! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on whether
PDF.writeis called withcompressset toTrueorFalse, two almost distinct code paths are taken. Ensure we exercise both code paths.