Add basic auth deprecation warnings for May 3rd retirement#295
Open
samsolaimani wants to merge 4 commits intomasterfrom
Open
Add basic auth deprecation warnings for May 3rd retirement#295samsolaimani wants to merge 4 commits intomasterfrom
samsolaimani wants to merge 4 commits intomasterfrom
Conversation
Notifies users via terminal whenever basic authentication (network password) is used, directing them to migrate to OAuth2 refresh tokens. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@samsolaimani looking at this now |
Contributor
Bug: Deprecation warning shows 3 times per commandWhen running
Each call hits the password path and triggers Suggested fix: Add a module-level flag in let deprecationWarningShown = false;
// ... inside the password branch:
if (!deprecationWarningShown) {
showBorderedMessage(
80,
yellow(
'⚠ DEPRECATION WARNING: Basic Authentication (network password) will be\n' +
' retired on May 3rd. Please run `alks developer configure` to migrate\n' +
' to OAuth2 (refresh token) authentication.'
)
);
deprecationWarningShown = true;
}Reproduced with: |
Contributor
|
@samsolaimani Do we want to show the Deprecation warnings 3 times? One time when we pick basic auth and then one time when we make a session I think is good. In the PR I have a suggestion on how to fix. |
DevOpsDave
requested changes
Feb 25, 2026
Contributor
DevOpsDave
left a comment
There was a problem hiding this comment.
@samsolaimani see my comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
alks developer loginalks developer configureto reflect the May 3rd retirement datehttps://alks.coxautoinc.comwithout the required/restpathTest plan
Basic auth deprecation warning
alkscommand (e.g.sessions open) configured with basic auth — confirm the yellow deprecation warning banner appears in the terminalalks developer login— confirm warning appears before credential promptsalks developer configure— confirm password choice shows "(DEPRECATED - retiring May 3rd, not recommended)""Did you mean?" server URL hint
ALKS_SERVER=https://alks.coxautoinc.comand runalks sessions open— confirm the yellow tip appears: "Did you mean https://alks.coxautoinc.com/rest?"ALKS_SERVER=https://alks.coxautoinc.com/(trailing slash) and runalks sessions open— confirm tip still appearsALKS_SERVER=https://alks.coxautoinc.com/restand runalks sessions open— confirm no tip appearsRally
US1879500: Create warning for ALKS CLI basic auth deprecation