Implement function replacement in string.gsub with comprehensive tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CppCXY
reviewed
Jan 19, 2026
| Ok((success, results)) => { | ||
| if success && !results.is_empty() { | ||
| let replacement = if results[0].is_nil() { | ||
| s_str[m.start..m.end].to_string() |
Owner
There was a problem hiding this comment.
you can repalce with result.push_str(s_str[m.start..m.end]) donot need to_string
MillhioreBT
force-pushed
the
string_replacement_with_function
branch
from
9eb5e72 to
ce58a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #12
line 342 auto-formatted, sorry.