-
Notifications
You must be signed in to change notification settings - Fork 5
add xmake lib #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @CppCXY, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive Lua path utility library, designed to provide robust cross-platform path manipulation capabilities. It aims to centralize and standardize path operations, offering functions for normalization, joining, splitting, and converting paths, as well as specialized handling for environment variables, thereby enhancing code consistency and maintainability across different operating systems. The addition of an object-oriented Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds EmmyLua annotations for the path standard library, which will improve static analysis and code completion for xmake scripts. The definitions for the path module and pathobj class are comprehensive. I've found a couple of minor issues with the annotation of variadic functions and suggested corrections to align with the EmmyLua standard.
|
|
||
| --- 拼接路径(自动加入分隔符并转换) | ||
| ---@param p string|pathobj | ||
| ---@param ... string|pathobj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The annotation ---@param ... is not the standard way to specify typed variadic arguments in EmmyLua. To correctly document the variadic arguments for this function, you should use ---@vararg instead. This will ensure that static analysis tools correctly interpret the function signature.
---@vararg string|pathobj
| function pathobj:relative(rootdir) end | ||
|
|
||
| --- 连接子路径(返回新实例) | ||
| ---@param ... string|pathobj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.