-
Notifications
You must be signed in to change notification settings - Fork 286
Update LogService class in CppMicroServices #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6482fe3
Update LogService class
ce326b1
Resolve Github action comments
a9ba09e
Address feedback
31319a8
Incorporating feedback
0e0321e
Incorporated feedbacks
c64af4b
Modified test
83a7ac2
Incorporated feedback
50c9d6e
Merge branch 'development' into logService
architapruthi 6e2380b
Merge branch 'development' into logService
architapruthi 2cd84b2
Feedback addressed
e8b4bc9
Address feedback
d31d109
Merge branch 'logService' of https://github.com/CppMicroServices/CppM…
d6da11a
Update Logger.hpp file
762d7ee
Modifications
e69303e
Modifying CFRLogger
b194f5c
Modifications
4886d62
Reverting one change
e34fe09
Making required change
b205784
Reducing code redundancy
7695495
Running clang-format
8f1c51d
Running clang-format
d2ddd10
Merge branch 'development' into logService
architapruthi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| #ifndef CPPMICROSERVICES_LOGGER_H_ | ||
| #define CPPMICROSERVICES_LOGGER_H_ | ||
|
|
||
| #include "cppmicroservices/ServiceReferenceBase.h" | ||
|
|
||
| #include <cstdint> | ||
| #include <exception> | ||
| #include <string> | ||
| #include <functional> | ||
|
|
||
|
|
||
| namespace cppmicroservices::logservice | ||
| { | ||
| /** @}*/ | ||
|
|
||
| /** | ||
| * \ingroup MicroService | ||
| * \ingroup gr_logservice | ||
| * | ||
| * Provides methods for bundles to write messages to the log. | ||
| * Logger interface defines several methods for each of the defined LogLevels. | ||
| * | ||
| */ | ||
|
|
||
| class Logger | ||
architapruthi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
| public: | ||
|
|
||
| virtual ~Logger() = default; | ||
|
|
||
| virtual void audit(const std::string& message) = 0; | ||
| virtual void audit(const std::string& format, const std::string& arg) = 0; | ||
| virtual void audit(const std::string& format, const std::string& arg1, const std::string& arg2) = 0; | ||
| virtual void audit(const std::string& message, const std::exception_ptr ex) = 0; | ||
| virtual void audit(const std::string& message, const ServiceReferenceBase& sr) = 0; | ||
| virtual void audit(const std::string& message, const ServiceReferenceBase& sr, const std::exception_ptr ex) = 0; | ||
|
|
||
| virtual void debug(const std::string& message) = 0; | ||
| virtual void debug(const std::string& format, const std::string& arg) = 0; | ||
| virtual void debug(const std::string& format, const std::string& arg1, const std::string& arg2) = 0; | ||
| virtual void debug(const std::string& message, const std::exception_ptr ex) = 0; | ||
| virtual void debug(const std::string& message, const ServiceReferenceBase& sr) = 0; | ||
| virtual void debug(const std::string& message, const ServiceReferenceBase& sr, const std::exception_ptr ex) = 0; | ||
|
|
||
| virtual void error(const std::string& message) = 0; | ||
| virtual void error(const std::string& format, const std::string& arg) = 0; | ||
| virtual void error(const std::string& format, const std::string& arg1, const std::string& arg2) = 0; | ||
| virtual void error(const std::string& message, const std::exception_ptr ex) = 0; | ||
| virtual void error(const std::string& message, const ServiceReferenceBase& sr) = 0; | ||
| virtual void error(const std::string& message, const ServiceReferenceBase& sr, const std::exception_ptr ex) = 0; | ||
|
|
||
| virtual void info(const std::string& message) = 0; | ||
| virtual void info(const std::string& format, const std::string& arg) = 0; | ||
| virtual void info(const std::string& format, const std::string& arg1, const std::string& arg2) = 0; | ||
| virtual void info(const std::string& message, const std::exception_ptr ex) = 0; | ||
| virtual void info(const std::string& message, const ServiceReferenceBase& sr) = 0; | ||
| virtual void info(const std::string& message, const ServiceReferenceBase& sr, const std::exception_ptr ex) = 0; | ||
|
|
||
| virtual void trace(const std::string& message) = 0; | ||
| virtual void trace(const std::string& format, const std::string& arg) = 0; | ||
| virtual void trace(const std::string& format, const std::string& arg1, const std::string& arg2) = 0; | ||
| virtual void trace(const std::string& message, const std::exception_ptr ex) = 0; | ||
| virtual void trace(const std::string& message, const ServiceReferenceBase& sr) = 0; | ||
| virtual void trace(const std::string& message, const ServiceReferenceBase& sr, const std::exception_ptr ex) = 0; | ||
|
|
||
| virtual void warn(const std::string& message) = 0; | ||
| virtual void warn(const std::string& format, const std::string& arg) = 0; | ||
| virtual void warn(const std::string& format, const std::string& arg1, const std::string& arg2) = 0; | ||
| virtual void warn(const std::string& message, const std::exception_ptr ex) = 0; | ||
| virtual void warn(const std::string& message, const ServiceReferenceBase& sr) = 0; | ||
| virtual void warn(const std::string& message, const ServiceReferenceBase& sr, const std::exception_ptr ex) = 0; | ||
architapruthi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| }; | ||
| } // namespace cppmicroservices | ||
|
|
||
| #endif // CPPMICROSERVICES_LOG_SERVICE_H__ | ||
48 changes: 48 additions & 0 deletions
48
compendium/LogService/include/cppmicroservices/logservice/LoggerFactory.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /*============================================================================= | ||
|
|
||
| Library: CppMicroServices | ||
|
|
||
| Copyright (c) The CppMicroServices developers. See the COPYRIGHT | ||
| file at the top-level directory of this distribution and at | ||
| https://github.com/CppMicroServices/CppMicroServices/COPYRIGHT . | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
|
|
||
| =============================================================================*/ | ||
| #ifndef CPPMICROSERVICES_LOGGER_FACTORY_H_ | ||
| #define CPPMICROSERVICES_LOGGER_FACTORY_H_ | ||
| #include "cppmicroservices/logservice/Logger.hpp" | ||
| #include "cppmicroservices/Bundle.h" | ||
|
|
||
| #include <cstdint> | ||
| #include <exception> | ||
| #include <string> | ||
| #include <memory> | ||
|
|
||
| namespace cppmicroservices::logservice | ||
| { | ||
| class LoggerFactory | ||
architapruthi marked this conversation as resolved.
Show resolved
Hide resolved
architapruthi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| public: | ||
|
|
||
| inline static const std::string ROOT_LOGGER_NAME = "ROOT"; | ||
|
|
||
| virtual ~LoggerFactory() = default; | ||
|
|
||
| [[nodiscard]] virtual std::shared_ptr<Logger> getLogger(std::string const& name = ROOT_LOGGER_NAME) const = 0; | ||
|
|
||
| [[nodiscard]] virtual std::shared_ptr<Logger> getLogger(cppmicroservices::Bundle bundle, std::string const& name = ROOT_LOGGER_NAME) const = 0; | ||
architapruthi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
architapruthi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }; | ||
| } | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.