Skip to content

Update to exception handling #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
augustak merged 3 commits into from
Oct 3, 2025
Merged

Update to exception handling #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de9613e
Update to exception handling
augustak Oct 3, 2025
fa48dd7
update
augustak Oct 3, 2025
be2388c
Update
augustak Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "cradl"
version = "0.4.3"
version = "0.4.4"
description = "Python SDK for Cradl"
authors = [{ name = "Cradl", email = "[email protected]" }]
readme = "README.md"
Expand Down
6 changes: 4 additions & 2 deletions src/cradl/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ def dictstrip(d):
return {k: v for k, v in d.items() if v is not None}


def _fatal_code(e):
return 400 <= e.response.status_code < 500
def _fatal_code(e: RequestException):
if hasattr(e, 'response') and isinstance(e.response.status_code, int):
return 400 <= e.response.status_code < 500
raise e


class Client:
Expand Down
Loading