Skip to content

Modernize typing syntax to Python 3.10+ standards #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
al-rigazzi merged 91 commits into from
Dec 17, 2025

Remove now-unused import

f074452
Select commit
Loading
Failed to load commit list.
Merged

Modernize typing syntax to Python 3.10+ standards #791

Remove now-unused import
f074452
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 16, 2025 in 1s

80.13% (target 0.00%)

View this Pull Request on Codecov

80.13% (target 0.00%)

Details

Codecov Report

❌ Patch coverage is 95.22388% with 16 lines in your changes missing coverage. Please review.
βœ… Project coverage is 80.13%. Comparing base (d7d979e) to head (f074452).
⚠️ Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
smartsim/_core/launcher/util/launcherUtil.py 0.00% 5 Missing ⚠️
smartsim/_core/launcher/dragon/dragonLauncher.py 55.55% 4 Missing ⚠️
smartsim/_core/launcher/sge/sgeLauncher.py 50.00% 3 Missing ⚠️
smartsim/_core/launcher/dragon/dragonBackend.py 87.50% 2 Missing ⚠️
smartsim/_core/launcher/launcher.py 50.00% 1 Missing ⚠️
smartsim/_core/launcher/step/sgeStep.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
- Coverage    83.91%   80.13%   -3.78%     
===========================================
  Files           83       78       -5     
  Lines         6284     6081     -203     
===========================================
- Hits          5273     4873     -400     
- Misses        1011     1208     +197
Files with missing lines Coverage Ξ”
smartsim/_core/config/config.py 98.21% <100.00%> (+1.07%) ⬆️
smartsim/_core/control/controller.py 82.98% <100.00%> (-2.25%) ⬇️
smartsim/_core/control/job.py 93.33% <100.00%> (-2.70%) ⬇️
smartsim/_core/control/jobmanager.py 93.46% <100.00%> (-0.70%) ⬇️
smartsim/_core/control/manifest.py 87.91% <100.00%> (-8.01%) ⬇️
smartsim/_core/control/previewrenderer.py 96.00% <100.00%> (-0.08%) ⬇️
smartsim/_core/generation/generator.py 96.77% <100.00%> (-0.03%) ⬇️
smartsim/_core/generation/modelwriter.py 100.00% <100.00%> (ΓΈ)
smartsim/_core/launcher/colocated.py 94.89% <100.00%> (-2.93%) ⬇️
smartsim/_core/launcher/dragon/dragonConnector.py 67.65% <100.00%> (-0.14%) ⬇️
... and 47 more

... and 4 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov