Skip to content

feat: per-year holidays#276

Draft
NecroKote wants to merge 8 commits intoCrazy-Marvin:developmentfrom
NecroKote:feat/exclude-holidays
Draft

feat: per-year holidays#276
NecroKote wants to merge 8 commits intoCrazy-Marvin:developmentfrom
NecroKote:feat/exclude-holidays

Conversation

@NecroKote
Copy link
Contributor

@NecroKote NecroKote commented May 17, 2025

Hi! It's me again :)

Today I bring you the "preview" of Holidays handling. (#266)

PR contains:

  • new Holidays Settings item
  • ability to add and remove Holidays for given year
  • ability to load country holidays from date.nager.at for given date (using 2 letter country code)
  • holidays are excluded during vacation and sick day calculations
  • holidays are displayed as vacations on calendar views
  • small bits and bobs - reusable components, small refactors and optimisations here and there

It's not a polished PR by any means, I just really wanted to get it to work.

Known issues:

  • 🐛 design flaws around holidays in general
  • 🐛 complete lack of user guidance around the feature
  • 🐛 no logic for handling collisions when loading holidays, e.g perform load twice - get twice the holidays! 🎉

Any feedback is appreciated!

@CrazyMarvin
Copy link
Contributor

Hey @NecroKote,
thanks again for an awesome PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants