[pull] dev from ArchiveBox:dev #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ME_ARGS This fix resolves issue #1445 where SingleFile was not respecting Chrome user data directory and other Chrome launch options that work for other Chrome-based extractors (PDF, Screenshot, etc.). Changes: - Added SINGLEFILE_CHROME_ARGS config option in config.json with x-fallback to CHROME_ARGS - Updated SingleFile extractor to read and pass Chrome arguments via --browser-args parameter - Updated docstring to document the new environment variable This ensures SingleFile respects the same Chrome configuration (user data directory, cookies, etc.) as other Chrome-based extractors. Fixes #1445 Co-authored-by: Nick Sweeting <[email protected]>
…ME_ARGS (#1754) Fixes #1445 This PR resolves the issue where SingleFile was not respecting Chrome user data directory and other Chrome launch options that work for other Chrome-based extractors (PDF, Screenshot, etc.). ## Changes - Added `SINGLEFILE_CHROME_ARGS` config option with fallback to `CHROME_ARGS` - Updated SingleFile extractor to pass Chrome arguments via `--browser-args` - Updated documentation This ensures SingleFile respects the same Chrome configuration as other Chrome-based extractors. Generated with [Claude Code](https://claude.ai/code)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )