[pull] main from googleapis:main#219
Merged
pull[bot] merged 3 commits intoCrazyForks:mainfrom Mar 17, 2026
Merged
Conversation
This PR introduces an auto-cleanup mechanism to address flakiness in the Cloud Healthcare integration tests caused by accumulation of orphaned resources (arising from abrupt CI terminations or local cancellations). Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
## Summary Fix Oracle go-ora DSN construction so proxy usernames with brackets (`user[client]`) are handled correctly and pre-encoded usernames are not double-encoded. Fixes #2454. ## Root cause `buildGoOraConnString` built DSNs using `url.URL{Host: connectStringBase, User: url.UserPassword(...)}`. For Oracle connect strings like `host:1521/SERVICE`, putting the full value in `Host` is lossy for URL formatting and brittle for userinfo handling. Also, when a username is already percent-encoded (`user%5Bclient%5D`), passing it directly to `url.UserPassword` can double-encode `%` without normalization. ## Fix - Normalize user/password with `url.PathUnescape` before URL userinfo encoding. - Construct DSN as: - encoded userinfo (`url.UserPassword(...).String()`) - raw Oracle connect string appended after `@` (preserves `host:port/service` shape) - Preserve wallet query args behavior (`ssl=true&wallet=...`). ## Tests Added regression coverage in `internal/sources/oracle/oracle_connstring_test.go`: - bracketed proxy username is encoded correctly. - already percent-encoded proxy username is not double-encoded. - existing wallet/non-wallet DSN cases remain correct. ## Validation - `go test ./internal/sources/oracle -run 'TestBuildGoOraConnString|TestParseFromYamlOracle|TestFailParseFromYaml'` --------- Co-authored-by: DEVELOPER-DEEVEN <144827577+DEVELOPER-DEEVEN@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )