Skip to content

Implement macOS cold start fix in GUI_App to store URL for post-initi… #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arlieeee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement macOS cold start fix in GUI_App to store URL for post-initi… #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/slic3r/GUI/GUI_App.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10317,6 +10317,18 @@ void GUI_App::MacOpenURL(const wxString& url)
{
if (url.empty())
return;

// Fix for macOS cold start: If not yet post-initialized, store the URL in
// init_params->input_files so that post_init() will detect it and set
// switch_to_3d = true. This prevents trigger_restore_project() from calling
// new_project() which would clear the model that will be loaded from this URL.
// This makes macOS behavior consistent with Windows.
if (!m_post_initialized) {
BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": cold start detected, storing URL to init_params: " << url.ToStdString();
this->init_params->input_files.emplace_back(into_u8(url));
return; // post_init() will call start_download() for us
}

start_download(boost::nowide::narrow(url));
}

Expand Down