Allow serialization/unserialization of objects on mixed properties#87
Merged
Allow serialization/unserialization of objects on mixed properties#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
mixedproperties didn't support objects. They would fail with a circular dependency due to how mixed properties are handled. That's sub-optimal, especially when union types are not supported.This PR resolves the circular dependency, albeit in a slightly not-nice way. Additionally, it provides support for deserializing into an object on a mixed property, but at the expense of allowing arrays when deserializing. Frankly that's an edge case, and if you have a
mixedproperty it should be serialized only, but some APIs are dumb, so we provide some support for it.Types of changes
This fix was sponsored by my employer, MakersHub.