Merged
Conversation
2Jin1031
reviewed
Dec 28, 2025
Collaborator
2Jin1031
left a comment
2Jin1031
left a comment
There was a problem hiding this comment.
고생했어요! 체체~
DocumentServiceJava를 DocumentService 내로 포함시키는 건 어떨까요? 원래 코틀린 마이그레이션을 대비해서 분리했던 거라, 이번 PR에서 함께 정리하면 좋을 것 같습니다.
| return ApiResponseGenerator.success(documentServiceJava.searchOrganizationDocument(uuid)); | ||
| } | ||
|
|
||
| private <T> ResponseDto<List<T>> convertToResponse(Page<T> pageResponses) { |
Collaborator
There was a problem hiding this comment.
p2) 나중에 서비스 로직으로 들어가도 되겠네요~
Member
Author
There was a problem hiding this comment.
이건 유틸성이 강해보인다고 생각하는데 어떠신가용 ~?
Collaborator
There was a problem hiding this comment.
그르네요
DTO 형태는 서비스 책임이라고 생각해서 한 말이었는데 다시 보니 오해의 소지가 있을 수 있겠군요
convertToResponse는 유틸 클래스로 빼고,
DTO를 반환하는 결정을 서비스에서 끝내는 구조는 어떻게 생각하시나요~?
Member
Author
There was a problem hiding this comment.
좋습니다~ 현재 PR은 마이그레이션만 진행을 마치고 새로운 이슈로 파는 게 좋아보여서 머지할게요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.