Merged
Conversation
Collaborator
Starlight258
commented
Jan 11, 2026
Starlight258
commented
- 조직 문서와 크루 문서 모두가 조회되는지 확인한다.
- 조직 문서와 크루 문서 모두가 조회되는지 확인한다.
2Jin1031
approved these changes
Jan 11, 2026
Collaborator
2Jin1031
left a comment
2Jin1031
left a comment
There was a problem hiding this comment.
고생하셨어요~ 밍트!
테스트 코드 깔끔하네요 🤩
| void findAll_success_returnsBothCrewAndOrganizationDocuments() { | ||
| // given | ||
| CrewDocument crewDocument = documentRepository.save( | ||
| DocumentFixture.createCrewDocument("crew문서", "content1", "writer1", 10L, UUID.randomUUID())); |
Collaborator
There was a problem hiding this comment.
p5) 메서드마다 save 로직의 반환값 처리 방식이 다르게 작성되어 보여요! 저장 결과를 이후 로직에서 사용하지 않는 경우에는 반환값을 변수로 받지 않도록 통일하여 일관성을 가져가는 것도 유지보수 측면에서 이점이 있다고 생각해서요 이 메서드의 given 절에서 사용하지 않는 반환값을 변수로 받는 부분을 제거하는 방향은 어떻게 생각하는 지 궁금합니다~
Collaborator
Author
There was a problem hiding this comment.
사용하지 않는 변수는 제거하는 것이 좋겠네요 👍 감사합니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.