Skip to content

Conversation

@pablo014
Copy link
Contributor

@pablo014 pablo014 commented May 20, 2024

This PR solves the zoom in and incident center issue.

In zooming the main issue was two things

  1. The hit box was sometimes too small to hit with a mouse causing users to zoom into a wrong area
  2. Sometimes the value of the maputil was not found so I made sure that there is always a maputils value before zooming in and out

In the jumping to incident center the main issue was that the coordinates being passed in were backwards

These were fixed by setting the coordinates correctly, increased the hit box for a given simple map and checking if there is a map utils value whenever you zoom in or out

@codecov
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 18.92%. Comparing base (9086dd2) to head (ec99dab).

Files with missing lines Patch % Lines
src/pages/phone/PhoneSystem.vue 0.00% 7 Missing ⚠️
src/components/SimpleMap.vue 0.00% 4 Missing ⚠️
src/components/tags/LanguageTag.vue 0.00% 1 Missing ⚠️
src/hooks/live/useLiveChart.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   18.92%   18.92%           
=======================================
  Files         434      434           
  Lines       69100    69102    +2     
  Branches     1492     1495    +3     
=======================================
+ Hits        13079    13080    +1     
- Misses      56021    56022    +1     
Flag Coverage Δ
unitTests 18.92% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented May 20, 2024

Playwright test results

failed  1 failed
passed  4 passed
flaky  1 flaky

Details

stats  6 tests across 5 suites
duration  6 minutes, 29 seconds
commit  ec99dab

Failed tests

chromium › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )

Flaky tests

chromium › pages/work.test.ts › WorkPage › should have visible data-testids - ( @primary @slow @read @development @staging @production )

@pablo014 pablo014 force-pushed the fix/simple-map-zoom branch from ef3754d to a7e5855 Compare May 21, 2024 23:09
@pablo014 pablo014 changed the title WIP: Phone System Zoom and Focus Issue Phone System Zoom and Focus Issue May 21, 2024
@pablo014 pablo014 requested a review from deepanchal May 21, 2024 23:38
@pablo014 pablo014 force-pushed the fix/simple-map-zoom branch from 2688192 to 8c7aeac Compare January 22, 2025 23:29
@pablo014 pablo014 force-pushed the fix/simple-map-zoom branch from 8c7aeac to 416c62f Compare February 6, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants