Refactor by manu-xmint · Pull Request #64 · Crossmint/n8n-nodes-crossmint

manu-xmint · 2026-01-21T20:56:23Z

Greptile Summary

Introduces a blockchain abstraction layer with provider interfaces and registry system to support multiple blockchain types beyond just Solana
Extracts reusable node property factories for wallet locators and chain selectors, eliminating 250+ lines of code duplication across wallet operations
Creates centralized export modules (shared/chains/index.ts, shared/nodeProperties/index.ts) to improve code organization and module boundaries

Important Files Changed

Filename	Overview
nodes/CrossmintWallets/CrossmintWallets.node.ts	Refactored to use extracted property functions, reducing file size from ~487 to ~402 lines by eliminating duplicated wallet locator definitions
shared/chains/solana/SolanaProvider.ts	New Solana provider implementation with incomplete 32-byte seed key support and mock context usage that needs cleanup
shared/chains/ChainRegistry.ts	New singleton registry for blockchain providers with automatic initialization that could cause import-time side effects
shared/nodeProperties/locator.properties.ts	New wallet locator property factory with comprehensive validation but throws errors instead of graceful fallbacks when chain types are unsupported
shared/chains/IChainProvider.ts	New blockchain provider interface defining the contract for multi-chain support with extensive method requirements

Sequence Diagram

sequenceDiagram
    participant User
    participant CrossmintWallets as "CrossmintWallets.node"
    participant ChainRegistry
    participant SolanaProvider
    participant CrossmintApi as "CrossmintApi"

    User->>CrossmintWallets: "Execute wallet operation"
    CrossmintWallets->>ChainRegistry: "getProvider(chainType)"
    ChainRegistry->>ChainRegistry: "initialize() if needed"
    ChainRegistry->>SolanaProvider: "new SolanaProvider()"
    ChainRegistry->>ChainRegistry: "register(provider)"
    ChainRegistry-->>CrossmintWallets: "return IChainProvider"
    CrossmintWallets->>SolanaProvider: "validateAddress(address)"
    SolanaProvider-->>CrossmintWallets: "ValidationResult"
    CrossmintWallets->>CrossmintApi: "execute operation (createWallet/getWallet/etc)"
    CrossmintApi-->>CrossmintWallets: "operation result"
    CrossmintWallets-->>User: "return execution data"

Context used (4)

Rule from dashboard - Use TypeScript instead of JavaScript for new projects, as TypeScript is the company's preferred lang... (source)
Rule from dashboard - When a function grows to 80+ lines, extract helper functions to improve readability and maintainabil... (source)
Rule from dashboard - Remove unused code from PRs to keep them lean. Add functionality later when it's actually needed. (source)
Rule from dashboard - Use generic Error exceptions for unexpected backend situations that should never happen, rather than... (source)

greptile-apps

_{8 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

shared/chains/ChainRegistry.ts

shared/nodeProperties/locator.properties.ts

shared/chains/solana/SolanaProvider.ts

greptile-apps

_{3 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-30T20:23:34Z

shared/chains/ChainFactory.ts

+	 */
+	static createProvider(chainType: string): IChainProvider | undefined {
+		switch (chainType.toLowerCase()) {
+			case 'solana':


Consider using CHAIN_TYPES.SOLANA constant from constants.ts instead of string literal for consistency with custom rule 0e60096d

Context Used: Rule from dashboard - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: shared/chains/ChainFactory.ts Line: 24:24 Comment: Consider using `CHAIN_TYPES.SOLANA` constant from `constants.ts` instead of string literal for consistency with custom rule 0e60096d **Context Used:** Rule from `dashboard` - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... ([source](https://app.greptile.com/review/custom-context?memory=0e60096d-0843-4800-801b-f8a78b766fbc)) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-30T20:23:35Z

shared/chains/ChainFactory.ts

+	 * @returns Array of supported chain type identifiers
+	 */
+	static getSupportedChainTypes(): string[] {
+		return ['solana'];


Consider using CHAIN_TYPES.SOLANA constant from constants.ts instead of string literal

Context Used: Rule from dashboard - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: shared/chains/ChainFactory.ts Line: 42:42 Comment: Consider using `CHAIN_TYPES.SOLANA` constant from `constants.ts` instead of string literal **Context Used:** Rule from `dashboard` - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... ([source](https://app.greptile.com/review/custom-context?memory=0e60096d-0843-4800-801b-f8a78b766fbc)) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-30T20:23:37Z

Additional Comments (2)

shared/utils/blockchain.ts
Hardcoded 'solana' string should use CHAIN_TYPES.SOLANA constant from constants.ts for consistency

			chainType: CHAIN_TYPES.SOLANA,

Context Used: Rule from dashboard - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review.
Path: shared/utils/blockchain.ts
Line: 43:43

Comment:
Hardcoded `'solana'` string should use `CHAIN_TYPES.SOLANA` constant from `constants.ts` for consistency

```suggestion
			chainType: CHAIN_TYPES.SOLANA,
```

**Context Used:** Rule from `dashboard` - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... ([source](https://app.greptile.com/review/custom-context?memory=0e60096d-0843-4800-801b-f8a78b766fbc))

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

shared/utils/constants.ts
CHAIN_TYPES constant is defined but never used in the codebase - consider using it in place of hardcoded string literals or removing it

Context Used: Rule from dashboard - Remove unused code from PRs to keep them lean. Add functionality later when it's actually needed. (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: shared/utils/constants.ts
Line: 12:14

Comment:
`CHAIN_TYPES` constant is defined but never used in the codebase - consider using it in place of hardcoded string literals or removing it

**Context Used:** Rule from `dashboard` - Remove unused code from PRs to keep them lean. Add functionality later when it's actually needed. ([source](https://app.greptile.com/review/custom-context?memory=83771aea-3c5f-4a37-9170-8ac881cd5efd))

How can I resolve this? If you propose a fix, please make it concise.

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-30T20:28:21Z

shared/chains/ChainFactory.ts

+	 */
+	static createProvider(chainType: string): IChainProvider | undefined {
+		switch (chainType.toLowerCase()) {
+			case 'solana':


Use CHAIN_TYPES.SOLANA constant from constants.ts instead of string literal for consistency and type safety.

Suggested change

case 'solana':

case CHAIN_TYPES.SOLANA:

Context Used: Rule from dashboard - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: shared/chains/ChainFactory.ts Line: 24:24 Comment: Use `CHAIN_TYPES.SOLANA` constant from `constants.ts` instead of string literal for consistency and type safety. ```suggestion case CHAIN_TYPES.SOLANA: ``` **Context Used:** Rule from `dashboard` - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... ([source](https://app.greptile.com/review/custom-context?memory=0e60096d-0843-4800-801b-f8a78b766fbc)) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-30T20:28:22Z

shared/chains/ChainFactory.ts

+	static getSupportedChainTypes(): string[] {
+		return ['solana'];


Use CHAIN_TYPES.SOLANA constant instead of string literal.

Suggested change

static getSupportedChainTypes(): string[] {

return ['solana'];

return [CHAIN_TYPES.SOLANA];

Context Used: Rule from dashboard - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: shared/chains/ChainFactory.ts Line: 41:42 Comment: Use `CHAIN_TYPES.SOLANA` constant instead of string literal. ```suggestion return [CHAIN_TYPES.SOLANA]; ``` **Context Used:** Rule from `dashboard` - Use enum constants (e.g., Chain.SOLANA, Chain.BASE) instead of string literals when comparing chain ... ([source](https://app.greptile.com/review/custom-context?memory=0e60096d-0843-4800-801b-f8a78b766fbc)) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

Blockchain Refactor

383db47

greptile-apps bot reviewed Jan 21, 2026

View reviewed changes

shared/chains/ChainRegistry.ts Outdated Show resolved Hide resolved

shared/nodeProperties/locator.properties.ts Show resolved Hide resolved

shared/chains/solana/SolanaProvider.ts Outdated Show resolved Hide resolved

shared/chains/solana/SolanaProvider.ts Show resolved Hide resolved

manu-xmint added 5 commits January 21, 2026 17:44

Refactor operations

db3b072

ChainRegistry changed to Factory

f1fcbb2

Fixed build

d6fd425

Fix regex

1cee260

Delete Hardcoded Solana

1b5440f

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

Fix Solana Address Validation

22a375f

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor#64

Refactor#64
manu-xmint wants to merge 7 commits intomainfrom
feature/refactor

manu-xmint commented Jan 21, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jan 30, 2026

Uh oh!

greptile-apps bot Jan 30, 2026

Uh oh!

greptile-apps bot commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jan 30, 2026

Uh oh!

greptile-apps bot Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		static getSupportedChainTypes(): string[] {
		return ['solana'];

	static getSupportedChainTypes(): string[] {
	return ['solana'];
	return [CHAIN_TYPES.SOLANA];

Conversation

manu-xmint commented Jan 21, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Important Files Changed

Sequence Diagram

Context used (4)

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

manu-xmint commented Jan 21, 2026 •

edited by greptile-apps bot

Loading