Skip to content

fix: ensure slash separator when joining URL paths (the base and endp… #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenany merged 1 commit into from
Dec 15, 2025
Merged

fix: ensure slash separator when joining URL paths (the base and endp… #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/crowdstrike_aidr/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ def _prepare_url(self, url: str) -> URL:
merge_url = URL(url)
if merge_url.is_relative_url:
base_url = self.base_url
merge_raw_path = base_url.raw_path + merge_url.raw_path.lstrip(b"/")
# Ensure exactly one slash separator between base and relative paths
merge_raw_path = base_url.raw_path.rstrip(b"/") + b"/" + merge_url.raw_path.lstrip(b"/")
return base_url.copy_with(raw_path=merge_raw_path)

return merge_url
Expand Down