Add env variable for POD_NODE_NAME to daemonset container #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The env variable is populated from spec.nodeName in the falcon-node-sensor container.
doyshinda
force-pushed
the
add_node_name_to_daemonset
branch
from
af5003f to
ccca07d
Compare
mr-jungchoi
previously approved these changes
Nov 19, 2025
mr-jungchoi
dismissed
their stale review
additional reconcile logic is required for updates in place
Contributor
|
Closing this PR and replacing it with #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env variable is populated from spec.nodeName in the falcon-node-sensor container.