Skip to content

feat(falcon-iar): Add unified IAR sensor support #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gpontejos-cs wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(falcon-iar): Add unified IAR sensor support #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/controller/falcon_image_analyzer/image_push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,17 @@ func (r *FalconImageAnalyzerReconciler) imageUri(ctx context.Context, falconImag
return "", fmt.Errorf("failed to set Falcon Image Analyzer Image version: %v", err)
}

if falconImageAnalyzer.Spec.Registry.Type == falconv1alpha1.RegistryTypeCrowdStrike {
semver := strings.Split(imageTag, "-")[0]
if !falcon_registry.IsMinimumUnifiedSensorVersion(semver, falcon.KacSensor) {
cloud, err := falconImageAnalyzer.Spec.FalconAPI.FalconCloudWithSecret(ctx, r.Reader, falconImageAnalyzer.Spec.FalconSecret)
if err != nil {
return "", err
}
registryUri = falcon.FalconContainerSensorImageURI(cloud, falcon.RegionedImageSensor)
}
}

return fmt.Sprintf("%s:%s", registryUri, imageTag), nil
}

Expand Down
8 changes: 8 additions & 0 deletions pkg/registry/falcon_registry/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const (
MinimumUnifiedNodeSensorVersion = "7.31.0"
MinimumUnifiedKacSensorVersion = "7.33.0"
MinimumUnifiedSidecarSensorVersion = "7.33.0"
MinimumUnifiedImageSensorVersion = "1.0.24"
)

func (reg *FalconRegistry) LastContainerTag(ctx context.Context, sensorType falcon.SensorType, versionRequested *string) (string, error) {
Expand Down Expand Up @@ -49,6 +50,11 @@ func (reg *FalconRegistry) LastContainerTag(ctx context.Context, sensorType falc
if err != nil {
tag, err = lastTag(ctx, systemContext, falcon.FalconContainerSensorImageURI(reg.falconCloud, falcon.RegionedSidecarSensor), regionedFilter)
}
case falcon.ImageSensor:
tag, err = lastTag(ctx, systemContext, falcon.FalconContainerSensorImageURI(reg.falconCloud, falcon.ImageSensor), unifiedFilter)
if err != nil {
tag, err = lastTag(ctx, systemContext, falcon.FalconContainerSensorImageURI(reg.falconCloud, falcon.RegionedImageSensor), regionedFilter)
}
default:
tag, err = lastTag(ctx, systemContext, reg.imageUriContainer(sensorType), regionedFilter)
}
Expand All @@ -68,6 +74,8 @@ func IsMinimumUnifiedSensorVersion(version string, sensorType falcon.SensorType)
return semver.Compare("v"+version, "v"+MinimumUnifiedKacSensorVersion) >= 0
case falcon.SidecarSensor:
return semver.Compare("v"+version, "v"+MinimumUnifiedSidecarSensorVersion) >= 0
case falcon.ImageSensor:
return semver.Compare("v"+version, "v"+MinimumUnifiedImageSensorVersion) >= 0
}

return false
Expand Down