add ability to have different confirmation messages in pgo, also remove the confirmation from the pgo backup command as not necessary

Author: Jeff McCormick

pgo/cmd/backup.go

@@ -23,7 +23,6 @@ import (
 	log "github.com/Sirupsen/logrus"
 	crv1 "github.com/crunchydata/postgres-operator/apis/cr/v1"
 	msgs "github.com/crunchydata/postgres-operator/apiservermsgs"
-	"github.com/crunchydata/postgres-operator/pgo/util"
 	"github.com/spf13/cobra"
 	"net/http"
 	"os"
@@ -39,11 +38,7 @@ var backupCmd = &cobra.Command{
 		if len(args) == 0 && Selector == "" {
 			fmt.Println(`You must specify the cluster to backup or a selector flag.`)
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
-				createBackup(args)
-			} else {
-				fmt.Println("Aborting...")
-			}
+			createBackup(args)
 		}
 
 	},

pgo/cmd/delete.go

@@ -99,7 +99,7 @@ var deleteIngestCmd = &cobra.Command{
 		if len(args) == 0 {
 			log.Error("a ingest name is required for this command")
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
+			if util.AskForConfirmation(NoPrompt, "") {
 				deleteIngest(args)
 			} else {
 				fmt.Println("Aborting...")
@@ -117,7 +117,7 @@ var deleteUpgradeCmd = &cobra.Command{
 		if len(args) == 0 {
 			log.Error("a database or cluster name is required for this command")
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
+			if util.AskForConfirmation(NoPrompt, "") {
 				deleteUpgrade(args)
 			} else {
 				fmt.Println("Aborting...")
@@ -135,7 +135,7 @@ var deleteBackupCmd = &cobra.Command{
 		if len(args) == 0 {
 			log.Error("a database or cluster name is required for this command")
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
+			if util.AskForConfirmation(NoPrompt, "") {
 				deleteBackup(args)
 			} else {
 				fmt.Println("Aborting...")
@@ -157,7 +157,7 @@ var deleteUserCmd = &cobra.Command{
 		} else if Selector == "" {
 			log.Error("a selector is required for this command")
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
+			if util.AskForConfirmation(NoPrompt, "") {
 				deleteUser(args[0])
 
 			} else {
@@ -177,7 +177,7 @@ var deleteClusterCmd = &cobra.Command{
 		if len(args) == 0 && Selector == "" {
 			log.Error("a cluster name or selector is required for this command")
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
+			if util.AskForConfirmation(NoPrompt, "") {
 				deleteCluster(args)
 
 			} else {
@@ -196,7 +196,7 @@ var deletePolicyCmd = &cobra.Command{
 		if len(args) == 0 {
 			log.Error("a policy name is required for this command")
 		} else {
-			if util.AskForConfirmation(NoPrompt) {
+			if util.AskForConfirmation(NoPrompt, "") {
 				deletePolicy(args)
 			} else {
 				fmt.Println("Aborting...")

pgo/cmd/failover.go

@@ -40,7 +40,7 @@ var failoverCmd = &cobra.Command{
 		} else {
 			if Query {
 				createFailover(args)
-			} else if util.AskForConfirmation(NoPrompt) {
+			} else if util.AskForConfirmation(NoPrompt, "") {
 				if Target == "" {
 					fmt.Println(`--target is required for failover.`)
 					return

pgo/cmd/upgrade.go

@@ -190,9 +190,9 @@ func validateCreateUpdate(args []string) error {
 	var err error
 
 	if UpgradeType == MajorUpgrade {
-		if util.AskForConfirmation(NoPrompt) {
+		if util.AskForConfirmation(NoPrompt, "") {
 		} else {
-			fmt.Println(`Aborting...`)
+			fmt.Println("Aborting...")
 			os.Exit(2)
 		}
 

pgo/util/confirmation.go

@@ -24,18 +24,22 @@ import (
 // confirmations. If the input is not recognized, it will ask again. The function does not return
 // until it gets a valid response from the user. Typically, you should use fmt to print out a question
 // before calling AskForConfirmation. E.g. fmt.Println("WARNING: Are you sure? (yes/no)")
-func AskForConfirmation(NoPrompt bool) bool {
+func AskForConfirmation(NoPrompt bool, msg string) bool {
 	var response string
 
 	if NoPrompt {
 		return true
 	}
-	fmt.Print("WARNING - This is destructive: Are you sure? (yes/no): ")
+	if msg == "" {
+		fmt.Print("WARNING - This is destructive: Are you sure? (yes/no): ")
+	} else {
+		fmt.Print("WARNING - " + msg + " (yes/no): ")
+	}
 
 	_, err := fmt.Scanln(&response)
 	if err != nil {
 		fmt.Println("Please type yes or no and then press enter:")
-		return AskForConfirmation(NoPrompt)
+		return AskForConfirmation(NoPrompt, msg)
 	}
 	okayResponses := []string{"y", "Y", "yes", "Yes", "YES"}
 	nokayResponses := []string{"n", "N", "no", "No", "NO", ""}
@@ -45,7 +49,7 @@ func AskForConfirmation(NoPrompt bool) bool {
 		return false
 	} else {
 		fmt.Println("Please type yes or no and then press enter:")
-		return AskForConfirmation(NoPrompt)
+		return AskForConfirmation(NoPrompt, msg)
 	}
 }