Upgrade pgBackRest settings from 4.2 and earlier

The format of pgBackRest secrets changed in 4.3, and operator settings
started being saved to the cluster in 4.4.

Issue: [ch9063]

Author: cbandy

internal/operator/cluster/upgrade.go

@@ -36,6 +36,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/fields"
 	"k8s.io/client-go/kubernetes"
+	"sigs.k8s.io/yaml"
 )
 
 // Store image names as constants to use later
@@ -411,6 +412,23 @@ func recreateBackrestRepoSecret(clientset kubernetes.Interface, clustername, nam
 	secretName := clustername + "-backrest-repo-config"
 	secret, err := clientset.CoreV1().Secrets(namespace).Get(secretName, metav1.GetOptions{})
 
+	// 4.1, 4.2
+	if err == nil {
+		if b, ok := secret.Data["aws-s3-ca.crt"]; ok {
+			config.BackrestS3CA = b
+		}
+		if b, ok := secret.Data["aws-s3-credentials.yaml"]; ok {
+			var parsed struct {
+				Key       string `yaml:"aws-s3-key"`
+				KeySecret string `yaml:"aws-s3-key-secret"`
+			}
+			if err = yaml.Unmarshal(b, &parsed); err == nil {
+				config.BackrestS3Key = parsed.Key
+				config.BackrestS3KeySecret = parsed.KeySecret
+			}
+		}
+	}
+
 	// >= 4.3
 	if err == nil {
 		if b, ok := secret.Data["aws-s3-ca.crt"]; ok {
@@ -514,6 +532,17 @@ func preparePgclusterForUpgrade(pgcluster *crv1.Pgcluster, parameters map[string
 	// cluster operations in this version of the Postgres Operator
 	pgcluster.ObjectMeta.Labels[config.LABEL_BACKREST] = "true"
 
+	// added in 4.2 and copied from configuration in 4.4
+	if pgcluster.Spec.BackrestS3Bucket == "" {
+		pgcluster.Spec.BackrestS3Bucket = operator.Pgo.Cluster.BackrestS3Bucket
+	}
+	if pgcluster.Spec.BackrestS3Endpoint == "" {
+		pgcluster.Spec.BackrestS3Endpoint = operator.Pgo.Cluster.BackrestS3Endpoint
+	}
+	if pgcluster.Spec.BackrestS3Region == "" {
+		pgcluster.Spec.BackrestS3Region = operator.Pgo.Cluster.BackrestS3Region
+	}
+
 	// added in 4.4
 	if pgcluster.Spec.BackrestS3VerifyTLS == "" {
 		pgcluster.Spec.BackrestS3VerifyTLS = operator.Pgo.Cluster.BackrestS3VerifyTLS