Improvements to Postgres Operator Ansible Inventory Validation

These changes improve the inventory validation to better ensure
the appropriate values are set before completing an Openshift or
Kubernetes Operator install. Most of the checking now happens during
preflight, meaning the problems are identified earlier.
Additionally, there are checks to see that the required values are not
just set but are also not null.

Author: tjmoore4

ansible/roles/pgo-preflight/tasks/check_openshift.yml

@@ -1,5 +1,14 @@
 # check_openshift.yml
 ---
+- name: openshift_token should be defined
+  assert:
+    that:
+      - openshift_token != ''
+    msg: "Set the value of 'openshift_token' in the inventory file."
+  when: 
+    - openshift_token is defined
+  tags: always
+
 - name: openshift_user should be defined
   assert:
     that:
@@ -16,16 +25,6 @@
   when: openshift_token is not defined
   tags: always
 
-- name: openshift_token should be defined
-  assert:
-    that:
-      - openshift_token is defined and openshift_token != ''
-    msg: "Set the value of 'openshift_token' in the inventory file."
-  when: 
-    - openshift_user is not defined
-    - openshift_password is not defined
-  tags: always
-
 - name: Check if the oc command is installed
   shell: which oc
   register: oc_result

ansible/roles/pgo-preflight/tasks/main.yml

@@ -11,7 +11,10 @@
 
 - name: Check if required Kube or OpenShift variables are defined
   fail: msg="Please specify either OpenShift or Kubernetes variables in inventory"
-  when: openshift_user is undefined and openshift_host is undefined and openshift_token is undefined and kubernetes_context is undefined
+  when: > 
+    (openshift_host is undefined or (openshift_host is defined and openshift_host == ''))
+    and (kubernetes_context is undefined or (kubernetes_context is defined and kubernetes_context == ''))
+    or ((openshift_host is defined and openshift_host != '') and (kubernetes_context is defined and kubernetes_context != ''))
   tags: always
 
 - include_tasks: check_openshift.yml