Look in more directories for Postgres binaries#4307
Merged
cbandy merged 1 commit intoCrunchyData:mainfrom Nov 17, 2025
Merged
Conversation
benjaminjb
approved these changes
Sep 30, 2025
Contributor
benjaminjb
left a comment
benjaminjb
left a comment
There was a problem hiding this comment.
LGTM, I'm curious about some of the knock-on effects of these changes / what potential issues we're warding off.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jmckulk
reviewed
Oct 1, 2025
|
|
||
| container.Command = []string{"patroni", configDirectory} | ||
| // Start Patroni in an environment that prioritizes executables of the specified Postgres version. | ||
| // NOTE: Patroni ignores PATH when "postgresql.bin_dir" is set. |
Collaborator
There was a problem hiding this comment.
Could users set this and break something?
Member
Author
There was a problem hiding this comment.
No. Patroni reads this setting from YAML files or environment variables, neither of which is configurable.
This comment was marked as resolved.
This comment was marked as resolved.
This makes PostgresCluster compatible with images from other distros. Issue: PGO-864
jmckulk
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #4304, but for PostgresCluster and Postgres images.
Checklist:
Type of Changes:
Other Information:
The last piece missing from the upgrade image is the
pgbackrestcommand.Issue: PGO-864