fix: update PNL percentage calculation to use margin as base #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cj4c0b1
commented
Oct 12, 2025
cj4c0b1
commented
- Changed PNL percentage calculation to use margin instead of notional value
- Updated both server-side (API) and client-side (PositionTable) calculations
- Now matches aster.dex ROE calculation: (unrealizedPnl / margin) * 100
- Fixes issue ROE% Calculation Mismatch with aster.dex #66
- Changed PNL percentage calculation to use margin instead of notional value - Updated both server-side (API) and client-side (PositionTable) calculations - Now matches aster.dex ROE calculation: (unrealizedPnl / margin) * 100 - Fixes issue CryptoGnome#66
…h existing orders
- Add OPTIMIZER_SELECTED_SYMBOLS environment variable support - Pass selected symbols from optimizer job to optimize-config.js - Improve logging and progress reporting during optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.