This repository was archived by the owner on Jan 17, 2026. It is now read-only.
Open
Conversation
4f6b83b to
6b1ab10
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR moves the elevator safety sensor away from the intake subsystem and integrates it directly into the elevator subsystem, addressing earlier design issues.
- Removed all references to the intake’s back sensor.
- Added safe sensor initialization and handling in elevator simulation and real components.
- Updated command wiring and autos to use the new elevator safety sensor, and updated the robot type constant.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/curtinfrc/frc2025/subsystems/intake/IntakeIOSim.java | Removed back sensor simulation lines |
| src/main/java/org/curtinfrc/frc2025/subsystems/intake/IntakeIOComp.java | Removed back sensor digital input |
| src/main/java/org/curtinfrc/frc2025/subsystems/intake/IntakeIO.java | Removed back sensor field |
| src/main/java/org/curtinfrc/frc2025/subsystems/intake/Intake.java | Removed back sensor trigger from intake subsystem |
| src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIOSim.java | Added simulation safe sensor initialization |
| src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIOComp.java | Added safe sensor digital input and inversion logic |
| src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIO.java | Added safe sensor field in inputs structure |
| src/main/java/org/curtinfrc/frc2025/subsystems/elevator/Elevator.java | Added safe trigger and updated goToSetpoint usage |
| src/main/java/org/curtinfrc/frc2025/Robot.java | Updated command bindings to use elevator.safe instead |
| src/main/java/org/curtinfrc/frc2025/Constants.java | Updated the robot type constant to SIMBOT |
| src/main/java/org/curtinfrc/frc2025/Autos.java | Updated auto routines to remove intake.backSensor usage |
Comments suppressed due to low confidence (2)
src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIOComp.java:66
- The inversion of the safe sensor reading may be unintuitive. Consider adding a comment or renaming the variable to clarify that the sensor returns an inverted logic value.
inputs.safe = !safe.get();
src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIO.java:13
- [nitpick] Consider renaming 'hominSensor' to 'homingSensor' for clarity.
public boolean hominSensor;
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
6b1ab10 to
7021844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing my own terrible design decisions