Skip to content
This repository was archived by the owner on Jan 17, 2026. It is now read-only.

Conversation

@spacey-sooty
Copy link
Member

Fixing my own terrible design decisions

@spacey-sooty spacey-sooty requested a review from a team as a code owner June 1, 2025 15:21
@spacey-sooty spacey-sooty force-pushed the jade/refactor-elevator-safety-sensor branch from 4f6b83b to 6b1ab10 Compare June 2, 2025 05:24
@spacey-sooty spacey-sooty requested a review from Copilot June 4, 2025 09:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the elevator safety sensor away from the intake subsystem and integrates it directly into the elevator subsystem, addressing earlier design issues.

  • Removed all references to the intake’s back sensor.
  • Added safe sensor initialization and handling in elevator simulation and real components.
  • Updated command wiring and autos to use the new elevator safety sensor, and updated the robot type constant.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/org/curtinfrc/frc2025/subsystems/intake/IntakeIOSim.java Removed back sensor simulation lines
src/main/java/org/curtinfrc/frc2025/subsystems/intake/IntakeIOComp.java Removed back sensor digital input
src/main/java/org/curtinfrc/frc2025/subsystems/intake/IntakeIO.java Removed back sensor field
src/main/java/org/curtinfrc/frc2025/subsystems/intake/Intake.java Removed back sensor trigger from intake subsystem
src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIOSim.java Added simulation safe sensor initialization
src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIOComp.java Added safe sensor digital input and inversion logic
src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIO.java Added safe sensor field in inputs structure
src/main/java/org/curtinfrc/frc2025/subsystems/elevator/Elevator.java Added safe trigger and updated goToSetpoint usage
src/main/java/org/curtinfrc/frc2025/Robot.java Updated command bindings to use elevator.safe instead
src/main/java/org/curtinfrc/frc2025/Constants.java Updated the robot type constant to SIMBOT
src/main/java/org/curtinfrc/frc2025/Autos.java Updated auto routines to remove intake.backSensor usage
Comments suppressed due to low confidence (2)

src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIOComp.java:66

  • The inversion of the safe sensor reading may be unintuitive. Consider adding a comment or renaming the variable to clarify that the sensor returns an inverted logic value.
inputs.safe = !safe.get();

src/main/java/org/curtinfrc/frc2025/subsystems/elevator/ElevatorIO.java:13

  • [nitpick] Consider renaming 'hominSensor' to 'homingSensor' for clarity.
public boolean hominSensor;

@spacey-sooty spacey-sooty force-pushed the jade/refactor-elevator-safety-sensor branch from 6b1ab10 to 7021844 Compare June 22, 2025 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants