Better Incident Manager Integration#33
Open
malvidin wants to merge 1 commit intoCybercentreCanada:masterfrom
Open
Better Incident Manager Integration#33malvidin wants to merge 1 commit intoCybercentreCanada:masterfrom
malvidin wants to merge 1 commit intoCybercentreCanada:masterfrom
Conversation
Draft use of toml/tomllib for default config Allow incident config section for assemblyline-incident-manager Extract read_config for reuse in assemblyline-incident-manager Separate TOML and ConfigParser loading
cccs-sgaron
approved these changes
May 15, 2023
Contributor
|
@malvidin This looks good, is that still a draft? |
malvidin
changed the title
Author
|
I had been thinking about how future integration of parameters could be included into a TOML file, like the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows incident config section for assemblyline-incident-manager, as well as refactoring reading the config for reuse in assemblyline-incident-manager.
Added draft use of toml/tomllib for default config, which could permit default
json-params,metadata, andsrv-specdictionaries to be set in the config.