- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 74
 
[Feature] Added ML-BOM examples #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Feature] Added ML-BOM examples #50
Conversation
34dcd38    to
    a5b7683      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding MLBOM, @galmo-noma . 👍
Could you modify your change request according to the remarks below?
        
          
                MLBOM/Dataset/bom.json
              
                Outdated
          
        
      | } | ||
| ], | ||
| "tags": [ | ||
| "task_categories:text-generation", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these values "tags" or are you intending to use properties which are name value pairs. These values seem to be hugging face specific which include the category:value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted these values to "properties", let me know if this is what you had in mind
| }, | ||
| "components": [ | ||
| { | ||
| "type": "data", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a data component but does not include a data property.  Data components should include the data property, Without it, the consumer does not know what kind of data this is (e.g. configuration, source code, dataset, etc). Refer to https://cyclonedx.org/docs/1.6/json/#components_items_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added data property. I noticed it includes also a contents.url property. Should I put the huggingface link here, in externalReferences.url, or both?
| "name": "Noma Security Inc." | ||
| } | ||
| }, | ||
| "components": [ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include a data subcomponent within the machine-learning-model? If so, that would tell the consumer information about the data used in this foundation model.
This component does not include the modelCard property, which it should.
Refer to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 
I was struggling to find what interesting information about GPT-4o should we add to the
modelCard, since we are not accessible to the datasets it was trained on, to the complete ethical considerations, etc . I added a proposal of describing the model architecture, and the inputs & outputs. let me know what do you think :) - 
Maybe I misunderstood, but as far as I understand, components that are not typed
data, should not have thedataproperty defined. Can you please advise?
(quote from here) 
| }, | ||
| "components": [ | ||
| { | ||
| "type": "machine-learning-model", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue here. The type does not have a modelCard property. And there should ideally be a data subcomponent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I added 
modelCardthat includes the datasets this huggingface model was trained on - (Same as above) Maybe I misunderstood, but as far as I understand, components that are not typed 
data, should not have thedataproperty defined. Can you please advise?
(quote from here) 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the time making those comments :)
        
          
                MLBOM/Dataset/bom.json
              
                Outdated
          
        
      | } | ||
| ], | ||
| "tags": [ | ||
| "task_categories:text-generation", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted these values to "properties", let me know if this is what you had in mind
| }, | ||
| "components": [ | ||
| { | ||
| "type": "data", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added data property. I noticed it includes also a contents.url property. Should I put the huggingface link here, in externalReferences.url, or both?
| "name": "Noma Security Inc." | ||
| } | ||
| }, | ||
| "components": [ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 
I was struggling to find what interesting information about GPT-4o should we add to the
modelCard, since we are not accessible to the datasets it was trained on, to the complete ethical considerations, etc . I added a proposal of describing the model architecture, and the inputs & outputs. let me know what do you think :) - 
Maybe I misunderstood, but as far as I understand, components that are not typed
data, should not have thedataproperty defined. Can you please advise?
(quote from here) 
| }, | ||
| "components": [ | ||
| { | ||
| "type": "machine-learning-model", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I added 
modelCardthat includes the datasets this huggingface model was trained on - (Same as above) Maybe I misunderstood, but as far as I understand, components that are not typed 
data, should not have thedataproperty defined. Can you please advise?
(quote from here) 
Signed-off-by: Gal Moyal <[email protected]>
Signed-off-by: Gal Moyal <[email protected]>
Signed-off-by: Gal Moyal <[email protected]>
Signed-off-by: Gal Moyal <[email protected]>
Signed-off-by: Gal Moyal <[email protected]>
7954269    to
    64378ba      
    Compare
  
    
Added basic examples for foundation model, open source model, and dataset