Introduce "cyclonedx rename-entity" command (bis)#396
Open
jimklimov wants to merge 2 commits intoCycloneDX:mainfrom
Open
Introduce "cyclonedx rename-entity" command (bis)#396jimklimov wants to merge 2 commits intoCycloneDX:mainfrom
jimklimov wants to merge 2 commits intoCycloneDX:mainfrom
Conversation
Primarily as a practical test case for Bom.WalkThis() and Bom.RenameBomRef() methods introduced in the library, but may be useful to have exposed for end-users. Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Member
|
basically this is supposed to change a known bom-ref to another bom-ref? I wrote this a tool cdx-enrich (will change the name to cdx-edit soon), I don't even use it myself yes, but this could be a good functionality for that tool as well. It can also take a list of operations, so if you plan to overwrite known bom-refs in a pipeline after creating a bom, this could work pretty good. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-introduce it in a sense: this was posted earlier as PR #346 and still relies on CycloneDX/cyclonedx-dotnet-library#245 for the bulk of work (
BomEntitybase-class and interface family, etc.) and CycloneDX/cyclonedx-dotnet-library#256 for metadata update of the output document.The earlier PR did not fail any formal tests (maybe should have added some, to ensure the contemporary library has the features exposed by it), so was prematurely merged and then reverted back by commit 91cf6c6 before cyclonedx-cli v0.26.0 release.