Skip to content

Commit 3eea1cf

Browse files
authored
ci: fix install of deps (#1316)
research: find why `tslib`is mising in some contexts see https://github.com/CycloneDX/cyclonedx-javascript-library/actions/runs/18498739588/job/52709606160#step:7:5032 and the fixes --------- Signed-off-by: Jan Kowalleck <[email protected]>
1 parent ab27577 commit 3eea1cf

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

.github/workflows/nodejs.yml

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ env:
2828

2929
jobs:
3030
build:
31-
name: build ${{ matrix.target }}
31+
name: "build: ${{ matrix.target }}"
3232
runs-on: "ubuntu-latest"
3333
strategy:
3434
fail-fast: false
@@ -203,20 +203,11 @@ jobs:
203203
NODE_VERSION: '${{ matrix.node-version }}'
204204
run: |
205205
set -ex
206-
207-
# for the purpose of testing strange setups,
208-
# we need to craft compatible versions by hand,
209-
# and might utilize `npm_config_engine_strict=false`
210-
211-
dev_constraints=' npm-run-all2 c8 mocha fast-glob memfs rimraf '
212-
echo "::group::install prod"
213-
npm_config_engine_strict=false npm i --ignore-scripts --include=optional --omit=dev --only=prod --production --loglevel=silly
214-
echo "::endgroup::"
215-
echo "::group::install dev"
216-
npm i --ignore-scripts --loglevel=silly --no-save $dev_constraints
206+
echo "::group::install project"
207+
npm i --ignore-scripts --include=optional --include=dev --loglevel=silly
217208
echo "::endgroup::"
218-
echo "::group::rebuild libxmljs2"
219209
## rebuild deps for which scripts were ignored, or partially installed - since "ignore-scripts" was used
210+
echo "::group::rebuild libxmljs2"
220211
npm rebuild --loglevel=silly libxmljs2 || npm uninstall --no-save libxmljs2 || true
221212
echo "::endgroup::"
222213
- name: fetch build artifact
@@ -468,7 +459,7 @@ jobs:
468459
working-directory: ${{ env.EXAMPLE_DIR }}
469460

470461
api-doc:
471-
name: api-doc ${{ matrix.target }}
462+
name: "api-doc: ${{ matrix.target }}"
472463
runs-on: "ubuntu-latest"
473464
strategy:
474465
fail-fast: false

.npmrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@
22

33
package-lock=false
44
engine-strict=true
5-
omit=peer # don't install them automatically; we take cate of them!

0 commit comments

Comments
 (0)