Skip to content

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 13, 2025

Added

  • Public export types.NodePackageJson, which is the input type for various factories and builders

this enables type checking downstream, like

  • const foo: NodePackageJson = {...}
  • const foo = {...} satisfies NodePackageJson

@jkowalleck jkowalleck requested a review from a team as a code owner July 13, 2025 18:05
@jkowalleck jkowalleck added the enhancement New feature or request label Jul 13, 2025
@codacy-production
Copy link

codacy-production bot commented Jul 13, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.17% (target: -1.00%) 83.67% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1e335d8) 26052 25615 98.32%
Head commit (3771d36) 26223 (+171) 25738 (+123) 98.15% (-0.17%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1263) 98 82 83.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck changed the title feat: public export of type PackageJson feat: public export of type NodePackageJson Jul 14, 2025
@jkowalleck jkowalleck merged commit 7089396 into main Jul 14, 2025
37 of 38 checks passed
@jkowalleck jkowalleck deleted the feat/type_PackageJson_public branch July 14, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants