-
-
Notifications
You must be signed in to change notification settings - Fork 28
fix: properly create outpur dir if needed #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the output file handling logic in the CLI to properly create the output directory before opening the file. The key improvement is extracting the directory path and checking for its existence before attempting to write the output file.
Key Changes:
- Refactored file descriptor handling to resolve the output path and create directories before opening the file
- Improved log message formatting by adding format specifiers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cli.ts | Refactored output file handling to properly resolve paths and create directories before opening file descriptors |
| HISTORY.md | Documented the fix for output directory creation issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
No description provided.