Skip to content

Conversation

@jkowalleck
Copy link
Member

No description provided.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner November 7, 2025 14:32
@jkowalleck jkowalleck added the bug Something isn't working label Nov 7, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from Copilot November 7, 2025 14:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the output file handling logic in the CLI to properly create the output directory before opening the file. The key improvement is extracting the directory path and checking for its existence before attempting to write the output file.

Key Changes:

  • Refactored file descriptor handling to resolve the output path and create directories before opening the file
  • Improved log message formatting by adding format specifiers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/cli.ts Refactored output file handling to properly resolve paths and create directories before opening file descriptors
HISTORY.md Documented the fix for output directory creation issue

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
r
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce6707c) 4278 3867 90.39%
Head commit (64ee9be) 4284 (+6) 3873 (+6) 90.41% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1377) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck jkowalleck merged commit 9b72237 into main Nov 10, 2025
28 checks passed
@jkowalleck jkowalleck deleted the fix/properly-create-output-dir-if-needed branch November 10, 2025 15:54
@jkowalleck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants