Skip to content

Conversation

jkowalleck
Copy link
Member

fixes #690

@jkowalleck jkowalleck added the bug Something isn't working label Oct 7, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner October 7, 2024 12:40
Copy link

codacy-production bot commented Oct 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% 95.65% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2aea159) 4512 4193 92.93%
Head commit (306fe65) 4516 (+4) 4198 (+5) 92.96% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#694) 23 22 95.65%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck changed the title fix: behaviour and typing of crypto setters woth optional values fix: behavior of and typing for crypto setters with optional values Oct 7, 2024
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck merged commit d8b20bd into main Oct 7, 2024
45 checks passed
@jkowalleck jkowalleck deleted the fix/crypto_optional_props branch October 7, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: '<' not supported between 'NoneType' and 'int' during certificate parsing
1 participant