BOM per binary, take 3 #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rget SBOMs Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
…rywhere for now. Looking kinda ugly ngl
… writing Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
…depaths go through it Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
…d finish the filename logic for it Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Shnatsel
force-pushed
the
bom-per-binary-3
branch
from
4d27882 to
855d00a
Compare
lfrancke
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Looking good to me.
I tried it on two repositories and the results look good.
When I had my PR for his (naive in comparison) I used the "lib" as a prefix so that the name of the artifact would look similar to the name of the SBOM.
But I also found out that the final name of an artifact is not currently exposed anywhere.
This might come with rust-lang/rfcs#3553
Anyway...good to go as is I think. There is no "correct" way to name these files so either way is good.
Just needs your DCO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--output-pattern=binaryand--output-pattern=cargo-targetmodes that emit SBOMs for compiled binaries and for all compilation targets (including Rust libraries that do not exist as standalone binaries) respectively.@lfrancke please test this and let me know if
--output-pattern=binaryfulfills your needs.