feat: add rootComponentBuildSystem configuration#1349
feat: add rootComponentBuildSystem configuration#1349jkowalleck merged 16 commits intoCycloneDX:masterfrom
Conversation
resolves CycloneDX#1344 Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
|
Thanks for the contribution, @jeremylong . 👍 I've done a quick review and kicked off the automated tests already. PS: got exited by your implementation and did the review already. :D |
|
I'm a little confused about the test failures - I don't see how these are related to the proposed change. |
dont worry. if you think they are unrelated, then you are probably right. |
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
jkowalleck
left a comment
jkowalleck
left a comment
There was a problem hiding this comment.
the implementation looks fantastic.
thanks a lot, @jeremylong
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
oops. i've modified the test bed's PS: i am on it |
|
sorry - broke the test when I updated the author. I forgot to update the snap... but you are working on this at the same time so I'm assuming you'll fix this as I don't want to interfere with your changes. |
no worries, it was I who broke the tests - #1349 (comment) I am adding some docs and details here and there, and will merge the feature soon. |
PR #1349, for some projects, ends up creating multiple duplicate `build-system` external references. The fix is to ensure we have not already added an external reference of type: `build-system`. With the current implementation, I've seen the plugin produce records like: ```json "externalReferences": [ { "url": "https://some.build.system.internal/job/88", "type": "build-system", "comment": "as declared via cyclonedx-webpack-plugin config \"rootComponentBuildSystem\"" }, { "url": "https://some.internal.vcs/org/repo", "type": "vcs", "comment": "as declared via cyclonedx-webpack-plugin config \"rootComponentVCS\"" }, { "url": "https://some.build.system.internal/job/88", "type": "build-system", "comment": "as declared via cyclonedx-webpack-plugin config \"rootComponentBuildSystem\"" }, { "url": "https://some.build.system.internal/job/88", "type": "build-system", "comment": "as declared via cyclonedx-webpack-plugin config \"rootComponentBuildSystem\"" }, { "url": "https://some.build.system.internal/job/88", "type": "build-system", "comment": "as declared via cyclonedx-webpack-plugin config \"rootComponentBuildSystem\"" } ] ``` fixes #1356 Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
2 participants
Adds the configuration for
rootComponentBuildSystemas discussed in #1344.resolves #1344