Skip to content

fix(XML): fixed aggregateType docs for incomplete_first_party_*#684

Merged
jkowalleck merged 1 commit intoCycloneDX:masterfrom
lime:first-party
Sep 12, 2025
Merged

fix(XML): fixed aggregateType docs for incomplete_first_party_*#684
jkowalleck merged 1 commit intoCycloneDX:masterfrom
lime:first-party

Conversation

@lime
Copy link
Contributor

@lime lime commented Sep 10, 2025

Fixes typos in 1.5 and 1.6 referring to third-party components, where first-party was intended.

Originally submitted as a fix for the guides in CycloneDX/guides#32.


TODO / DONE:

  • fix XML schema
  • fix JSON schema - was correct, already
  • fix PB schema - was correct, already

@lime lime requested a review from a team as a code owner September 10, 2025 06:19
Signed-off-by: Emil Sågfors <emil.sagfors@iki.fi>
@jkowalleck
Copy link
Member

need to triage if this is a bug, or intended behavior.

we usually dont "patch" older versions, while we are working on a newer one.
we are currently finalizing v1.7

if accepted, we need to forward-port this to 1.7

@jkowalleck jkowalleck added CDX 1.5 related to release v1.5 CDX 1.6 related to release v1.6 labels Sep 11, 2025
@jkowalleck
Copy link
Member

Triaged. This is a bug indeed.

@jkowalleck
Copy link
Member

the spec had the correct wording already, which this patch applies to the XML implementation.
will merge this.

thanks for the fix, @lime

@jkowalleck jkowalleck changed the title Fix reference to first/third-party components fix(XML): fixed aggregateType docs for incomplete_first_party_* Sep 12, 2025
@jkowalleck jkowalleck merged commit 6cf5d62 into CycloneDX:master Sep 12, 2025
9 checks passed
jkowalleck added a commit that referenced this pull request Sep 12, 2025
@lime lime deleted the first-party branch October 2, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CDX 1.5 related to release v1.5 CDX 1.6 related to release v1.6 defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants