Skip to content

Update ratings descriptions in schema files for clarity on VEX usage#722

Merged
stevespringett merged 6 commits intoCycloneDX:masterfrom
fahedouch:vex-ratings-actionable-cyclonedx-conumers
Feb 7, 2026
Merged

Update ratings descriptions in schema files for clarity on VEX usage#722
stevespringett merged 6 commits intoCycloneDX:masterfrom
fahedouch:vex-ratings-actionable-cyclonedx-conumers

Conversation

@fahedouch
Copy link
Contributor

I am translating @stevespringett 's feedback on the CycloneDX VEX specification into the code.

Should ratings be normative inputs for prioritization in VEX consumers?

Yes, they should be. It is widely known that the NVD has historically overrated vulnerabilities (on purpose). So the ratings from the NVD and those from the manufactures are often different. CycloneDX can convey this information which can aid in prioritization.

fixes #719

@fahedouch fahedouch force-pushed the vex-ratings-actionable-cyclonedx-conumers branch from b2b999a to 93da22f Compare November 15, 2025 11:11
@fahedouch
Copy link
Contributor Author

@stevespringett please take a look!

@stevespringett
Copy link
Member

I'm fine with these changes. @jkowalleck thoughts? We'll also need to make the same changes to the XML and protobuf schemas as well.

Additionally, you can remove the changes to the vulnerability extension. That hasn't been supported for many years.

@fahedouch fahedouch force-pushed the vex-ratings-actionable-cyclonedx-conumers branch 2 times, most recently from 688eef3 to da03911 Compare December 26, 2025 21:27
@fahedouch
Copy link
Contributor Author

@stevespringett thank you for your feedback. fixed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the documentation for the ratings field in vulnerability objects across CycloneDX schema files to provide normative guidance on their usage in VEX (Vulnerability Exploitability eXchange) contexts. Based on feedback from issue #719, the changes clarify that vulnerability ratings should be treated as actionable inputs for prioritization decisions by VEX consumers.

Changes:

  • Adds RFC 2119 normative language (SHOULD/SHOULD NOT) to the ratings field documentation across schema versions 1.6 and 1.7
  • Updates documentation in XSD, JSON Schema, and Protocol Buffer formats for consistency
  • Emphasizes that ratings from different sources may differ and aid in vulnerability prioritization

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
schema/bom-1.7.xsd Updated vulnerability ratings documentation to include guidance for VEX consumers
schema/bom-1.7.schema.json Updated vulnerability ratings description with normative language
schema/bom-1.7.proto Updated ratings comment to match normative guidance
schema/bom-1.6.xsd Updated vulnerability ratings documentation for version 1.6 compatibility
schema/bom-1.6.schema.json Updated vulnerability ratings description in JSON schema
schema/bom-1.6.proto Updated ratings comment in Protocol Buffer schema

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fahedouch
Copy link
Contributor Author

fahedouch commented Jan 17, 2026

thanks @copilot for review. I reflected @copilot comments.

new phrase is:

List of vulnerability ratings. Consumers SHOULD consider ratings in prioritization decisions; source ratings may differ and aid prioritization.

aid prioritization is preferable to provide valuable context for the following reasons:

It's more actionable - developers understand exactly why it matters
It's more transparent - if the true purpose is to assist with prioritization, it should be stated explicitly
It reinforces the message - it maintains consistency with "in prioritization decisions" in the first clause

@jkowalleck @stevespringett PTAL

jkowalleck
jkowalleck previously approved these changes Jan 21, 2026
Copy link
Member

@jkowalleck jkowalleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
… and revert extension changes

Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
…n VEX usage

Signed-off-by: Fahed Dorgaa <fahed.dorgaa@gmail.com>
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
… and revert extension changes

Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
@fahedouch fahedouch force-pushed the vex-ratings-actionable-cyclonedx-conumers branch from a075955 to 82770ac Compare February 5, 2026 17:23
Copy link
Member

@stevespringett stevespringett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and appologies for the delay. I noticed the JSON schemas have a different description than the XSD and Protobuf. Can you update the JSON schema description to match that of the XSD and Protobuf please.

The description should read:

List of vulnerability ratings. Consumers SHOULD consider ratings in prioritization decisions; source ratings may differ and aid prioritization.

Signed-off-by: Fahed Dorgaa <fahed.dorgaa@gmail.com>
@fahedouch fahedouch force-pushed the vex-ratings-actionable-cyclonedx-conumers branch from 97dd183 to 80db025 Compare February 7, 2026 21:36
@fahedouch
Copy link
Contributor Author

Thank you for the PR and appologies for the delay. I noticed the JSON schemas have a different description than the XSD and Protobuf. Can you update the JSON schema description to match that of the XSD and Protobuf please.

The description should read:

List of vulnerability ratings. Consumers SHOULD consider ratings in prioritization decisions; source ratings may differ and aid prioritization.

no worries. Fixed :)

@stevespringett stevespringett merged commit 251b1cd into CycloneDX:master Feb 7, 2026
9 checks passed
stevespringett added a commit that referenced this pull request Feb 7, 2026
Signed-off-by: Steve Springett <steve@springett.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make VEX Ratings Actionable in CycloneDX Consumers

3 participants