fix: reduce swap amount in UniswapV2Arb1 exercise test to match solution test#44
Merged
t4sk merged 1 commit intoCyfrin:mainfrom Jan 12, 2026
Merged
Conversation
…and prevent insufficient liquidity error
|
Thanks for the contribution. This will be attended to appropriately as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
uniswap-v2/exercises/UniswapV2Arb1.test.soluses an amountIn of10000 * 1e18. The solution test uses only10 * 1e18. Even if a correct solution is written for the exercise, the flashSwap test will fail due to an insufficient liquidity error. This fix will ensure the exercise test matches the solution test.