Add dialog for confirmation of delete #153 Part 3 #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please add the screenshot of the changes to the PR description.
…On Mon, Feb 25, 2019, 8:22 AM Sunitha Kandalam ***@***.***> wrote:
Fixed #153 <#153>
part 3 New component confirm in shared module.
Files changed / created:
src/app/profile/user/details/details.component.html.
src/app/profile/user/details/details.component.scss.
src/app/profile/user/details/details.component.ts.
src/app/profile/user/user.module.ts.
src/app/shared/confirm/confirm.component.html.
src/app/shared/confirm/confirm.component.scss.
src/app/shared/confirm/confirm.component.spec.ts.
src/app/shared/confirm/confirm.component.ts.
src/app/shared/idea-card/idea-card.component.ts.
src/app/shared/shared.module.ts.
------------------------------
You can view, comment on, or merge this pull request online at:
#170
Commit Summary
- new confirmation component
File Changes
- *M* src/app/profile/user/details/details.component.html
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-0>
(175)
- *M* src/app/profile/user/details/details.component.scss
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-1>
(21)
- *M* src/app/profile/user/details/details.component.ts
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-2>
(71)
- *M* src/app/profile/user/user.module.ts
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-3>
(13)
- *A* src/app/shared/confirm/confirm.component.html
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-4>
(7)
- *A* src/app/shared/confirm/confirm.component.scss
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-5>
(44)
- *A* src/app/shared/confirm/confirm.component.spec.ts
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-6>
(24)
- *A* src/app/shared/confirm/confirm.component.ts
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-7>
(21)
- *M* src/app/shared/idea-card/idea-card.component.ts
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-8>
(5)
- *M* src/app/shared/shared.module.ts
<https://github.com/Cynthesize/cynthesize-frontend/pull/170/files#diff-9>
(20)
Patch Links:
- https://github.com/Cynthesize/cynthesize-frontend/pull/170.patch
- https://github.com/Cynthesize/cynthesize-frontend/pull/170.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#170>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ArvXZ4S9Kr1U0Wlf8Dqi-jSz4yQdm8Ndks5vQ0_agaJpZM4bO--T>
.
|
WickedBrat
reviewed
Feb 25, 2019
| <div class="profile-header-info__photo"> | ||
| <cl-image height="150" crop="scale" public-id="{{ user.profile_pic }}" secure="true"></cl-image> | ||
| <cl-image | ||
| height="150" |
Member
There was a problem hiding this comment.
Please remove this auto-linting, else it will change multiple time to and fro.
Contributor
Author
There was a problem hiding this comment.
Can you please help me understand auto-linting? I use visual studio code, so should I disable something on it or do I need to change the code in details.component.html? I have disabled the lint on this workspace on my editor.
WickedBrat
reviewed
Feb 25, 2019
| Are you sure you want to delete? | ||
| </p> | ||
| <button class="btn" (click)="sendConfirmation(true)">YES</button> | ||
| <button class="btn" (click)="sendConfirmation(false)">NO</button> |
Member
There was a problem hiding this comment.
Use mat-action to take yes or no input. Eg:
<div mat-dialog-actions>
<button mat-button (click)="onNoClick()">No Thanks</button>
<button mat-button [mat-dialog-close]="data.animal" cdkFocusInitial>Ok</button>
</div>
Contributor
Author
There was a problem hiding this comment.
Made the changes in the code.
WickedBrat
requested changes
Feb 25, 2019
Member
WickedBrat
left a comment
WickedBrat
left a comment
There was a problem hiding this comment.
Left some comments, rest looks good. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #153 part 3 New component confirm in shared module.
Files changed / created:
src/app/profile/user/details/details.component.html.
src/app/profile/user/details/details.component.scss.
src/app/profile/user/details/details.component.ts.
src/app/profile/user/user.module.ts.
src/app/shared/confirm/confirm.component.html.
src/app/shared/confirm/confirm.component.scss.
src/app/shared/confirm/confirm.component.spec.ts.
src/app/shared/confirm/confirm.component.ts.
src/app/shared/idea-card/idea-card.component.ts.
src/app/shared/shared.module.ts.