feat: add [ServiceName] attribute #1031
Merged
+650
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your contribution! Can I add tests for the Source Generator and commit them? |
Contributor
Author
|
of course, thanks!
…On Thu, Feb 12, 2026 at 1:09 AM Mayuki Sawatari ***@***.***> wrote:
*mayuki* left a comment (Cysharp/MagicOnion#1031)
<#1031 (comment)>
Thank you for your contribution! Can I add tests for the Source Generator
and commit them?
—
Reply to this email directly, view it on GitHub
<#1031 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BTPE5WFPE3HRJO6KBEGU7ET4LQ7OLAVCNFSM6AAAAACUU4RO7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQOBZGY2TANJUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Closes Cysharp#1029 Allow service interfaces with the same short name in different namespaces to coexist on the same server by specifying a custom gRPC service name. - Add ServiceNameAttribute to MagicOnion.Abstractions for overriding the default interface-name-based gRPC routing path - Add ServiceNameHelper to resolve the service name from the attribute at runtime (dynamic client and server) - Update MethodCollector to resolve the service name from the attribute at source-generation time (static client) - Add ServiceName property to IMagicOnionServiceInfo interface - Validate against null/whitespace in ServiceNameAttribute constructor - Add unit, server, and integration tests for both unary and hub scenarios
jeff-at-trimble
force-pushed
the
issue-1029/service-naming
branch
from
d652fcd to
1c61dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1029
Allow service interfaces with the same short name in different namespaces to coexist on the same server by specifying a custom gRPC service name.