feat: add [ServiceName] attribute #1031
Open
+650
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Cysharp#1029 Allow service interfaces with the same short name in different namespaces to coexist on the same server by specifying a custom gRPC service name. - Add ServiceNameAttribute to MagicOnion.Abstractions for overriding the default interface-name-based gRPC routing path - Add ServiceNameHelper to resolve the service name from the attribute at runtime (dynamic client and server) - Update MethodCollector to resolve the service name from the attribute at source-generation time (static client) - Add ServiceName property to IMagicOnionServiceInfo interface - Validate against null/whitespace in ServiceNameAttribute constructor - Add unit, server, and integration tests for both unary and hub scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1029
Allow service interfaces with the same short name in different namespaces to coexist on the same server by specifying a custom gRPC service name.