Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 32.07% 34.97% +2.89%
==========================================
Files 215 215
Lines 36242 32974 -3268
Branches 14543 13142 -1401
==========================================
- Hits 11626 11532 -94
+ Misses 22692 19544 -3148
+ Partials 1924 1898 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8b6c42c to
282f955
Compare
IvanaGyro
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cytnx arithmetic implementation contained lots duplicated code across different type combinations, which caused:
This PR refines the Div CPU implementation, similar to #651.
Our goal is to generalize all arithmetic operations using templates, and eventually refactor the multiple-dispatch mechanism for arithmetic.
Next, we plan to replace the
linalg_internal::lii.Ari_iiusage in arithmetic .cpp files with thestd::variant+std::visitpattern, similar to what we did in commit 710c98c.This is the last PR for Arithmetic OPs.