Skip to content

Fix diag nodiag #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuschneider wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix diag nodiag #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a640816
fixed elementwise arithmetics between diagonal and non-diagonal Dense…
manuschneider Nov 25, 2025
8999f45
added operator-() for UniTensor and fixed unwanted type conversion fo…
manuschneider Nov 25, 2025
30642e7
added unit tests for Add(_), Sub(_), Mul(_), Div(_) between diagonal …
manuschneider Nov 25, 2025
d48f06f
removed changes to operator-(), since this is a different topic
manuschneider Nov 25, 2025
4181138
unit test does not depend on UniTensor.operator-() anymore
manuschneider Nov 25, 2025
7fa6d91
clang
manuschneider Nov 25, 2025
73a7931
Merge remote-tracking branch 'origin/master' into fix_diag_nodiag
manuschneider Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions src/DenseUniTensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ namespace cytnx {
} else {
// check bonds & labels dim
cytnx_error_msg(bonds.size() != in_labels.size(), "%s",
"[ERROR] labels must have same lenth as # of bonds.");
"[ERROR] labels must have same length as # of bonds.");

std::vector<std::string> tmp = vec_unique(in_labels);
cytnx_error_msg(tmp.size() != in_labels.size(),
Expand Down Expand Up @@ -1299,8 +1299,14 @@ namespace cytnx {
i);
}
}

this->_block += rhs->get_block_();
if (this->_is_diag == rhs->_is_diag) {
this->_block += rhs->get_block_();
} else if (this->_is_diag) {
this->to_dense_();
this->_block += rhs->get_block_();
} else {
this->_block += linalg::Diag(rhs->get_block_());
}
}
void DenseUniTensor::Add_(const Scalar &rhs) {
// cout << rhs << endl;
Expand Down Expand Up @@ -1329,7 +1335,14 @@ namespace cytnx {
i);
}
}
this->_block -= rhs->get_block_();
if (this->_is_diag == rhs->_is_diag) {
this->_block -= rhs->get_block_();
} else if (this->_is_diag) {
this->to_dense_();
this->_block -= rhs->get_block_();
} else {
this->_block -= linalg::Diag(rhs->get_block_());
}
}
void DenseUniTensor::Sub_(const Scalar &rhs) {
// cytnx_error_msg(this->is_tag(),"[ERROR] cannot perform arithmetic on tagged unitensor
Expand Down Expand Up @@ -1362,7 +1375,14 @@ namespace cytnx {
i);
}
}
this->_block *= rhs->get_block_();
if (this->_is_diag == rhs->_is_diag) {
this->_block *= rhs->get_block_();
} else if (this->_is_diag) {
this->to_dense_();
this->_block *= rhs->get_block_();
} else {
this->_block *= linalg::Diag(rhs->get_block_());
}
}
void DenseUniTensor::Mul_(const Scalar &rhs) {
// cytnx_error_msg(this->is_tag(),"[ERROR] cannot perform arithmetic on tagged unitensor
Expand Down Expand Up @@ -1390,7 +1410,16 @@ namespace cytnx {
i);
}
}
this->_block /= rhs->get_block_();
if (this->_is_diag == rhs->_is_diag) {
this->_block /= rhs->get_block_();
} else {
cytnx_error_msg(rhs->_is_diag,
"[Div] Dividing a non-diagonal DenseUnitensor by a diagonal one would lead "
"to divisions by zero!%s",
"\n");
this->to_dense_();
this->_block /= rhs->get_block_();
}
}
void DenseUniTensor::Div_(const Scalar &rhs) {
// cytnx_error_msg(this->is_tag(),"[ERROR] cannot perform arithmetic on tagged unitensor
Expand Down
Loading
Loading