Skip to content

Conversation

@jysh1214
Copy link
Collaborator

@jysh1214 jysh1214 commented Dec 6, 2025

  • Skip Int64 vs Int16 Cpr test due to unresolved issue

- Skip Int64 vs Int16 Cpr test due to unresolved issue
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.26%. Comparing base (e87c3a2) to head (e5f5cdc).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   32.35%   35.26%   +2.91%     
==========================================
  Files         215      215              
  Lines       36363    33095    -3268     
  Branches    14597    13196    -1401     
==========================================
- Hits        11764    11670      -94     
+ Misses      22659    19511    -3148     
+ Partials     1940     1914      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}

// Test tensor-to-tensor addition with mixed types
TEST_P(AddTestAllShapes, gpu_tensor_add_tensor_mixed_types) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this test already covers TEST_P(AddTestAllShapes, gpu_tensor_add_tensor_all_types). Is it fine the remove the following one?

Additionally, a comment in #723 mentioned there is a problem of type promotion. Will this problem be addressed in the following changes?

@jysh1214
Copy link
Collaborator Author

Let me modify each unit tests to use mioxed types one by one.

@jysh1214 jysh1214 closed this Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants