Fixed the build, TryFrom seems to be feature gated in num_bigint#1
Open
gamozolabs wants to merge 1 commit intoD0ntPanic:masterfrom
Open
Fixed the build, TryFrom seems to be feature gated in num_bigint#1gamozolabs wants to merge 1 commit intoD0ntPanic:masterfrom
gamozolabs wants to merge 1 commit intoD0ntPanic:masterfrom
Conversation
Author
|
Perhaps this is something weird about my environment. But I would expect https://github.com/rust-num/num-bigint/blob/master/build.rs#L19 should be detecting and setting this feature. I'm not sure why it is not. |
|
I have faced the same problem, and your fix seems to solve it. However, there is another problem (at least with my environment): |
|
Fixed this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the build. It seems
num_bigintgates behindTryFrom. I'm not sure if this is the right fix, as I would suspect this is something that should be auto-detected.