Fix invalid schema if unresponsive or invalid error #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishaschwartz
commented
Oct 22, 2025
Collaborator
Author
There was a problem hiding this comment.
I refactored this file as well even though they're technically unrelated to the current bug fix.
Basically, we were over-using the org_data variable in a lot of cases where it wasn't necessary.
fmigneault
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the status was set to "unresponsive" or "invalid_configuration" during an update, these would lead to an invalid schema since those statuses were not technically part of the schema.
This fixes that by adding those statuses to the schema and adds some tests to ensure that the final schema is always valid even if the services reported by the schema are themselves invalid.