Skip to content

add timeout #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mishaschwartz merged 1 commit into from
Oct 28, 2025
Merged

add timeout #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions marble_node_registry/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,17 @@ def update_registry() -> None:
version_url = link["href"]
try:
# This assumes the json is initially valid according to the schema
services_response = requests.get(services_url, headers={"Accept": "application/json"})
version_response = requests.get(version_url, headers={"Accept": "application/json"})
services_response = requests.get(services_url, headers={"Accept": "application/json"}, timeout=10)
version_response = requests.get(version_url, headers={"Accept": "application/json"}, timeout=10)
except requests.exceptions.ConnectionError as e:
# if either url fails, report that the node is offline
data["status"] = "offline"
sys.stderr.write(f"unable to access node named {name}. Error message: {e}\n")
continue
except requests.exceptions.Timeout as e:
data["status"] = "unresponsive"
sys.stderr.write(f"node named '{name}' is unrespsonsive. Error message: {e}\n")
continue

try:
data["version"] = version_response.json().get("version", "unknown")
Expand Down