Conversation
Added Pycharm specific ignore
- output widget messages no longer stack up except in the case of an invalid node name and empty user credentials - changed request.post() to session.post() - successful or erroneous login feedback messages is now the one from the server response - removed variables that are initialized as empty strings - changed success check condition to use response.json() - removed unneeded output widgets - added check for empty credentials
Add changelog items
Changed command name to marble_login
Added test to see if a code cell is added to the top of the notebook (index zero)
Removed command call
Removed email
Removed email
Add blank line to satisfy prettier linting error
Added tests (tests in progress)
Comment out test for now (test isn't working)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues noted in review of PR in marble-extension branch.
#1