Skip to content

Replace Marble logo with logo from Discourse #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandercyu wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace Marble logo with logo from Discourse #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aae54d1
Change Marble logo to svg from Discourse
alexandercyu Apr 24, 2024
5489a56
Create marbletutorial.css
alexandercyu Apr 24, 2024
8537780
Create marble-logo-text.svg
alexandercyu Apr 24, 2024
874dbaa
Delete marble.png
alexandercyu Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tutorials/_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
title: Marble Tutorials
author: Marble Community
copyright: "2024"
logo: "marble.png"
logo: "marble-logo-text.svg"

# Force re-execution of notebooks on each build.
# See https://jupyterbook.org/content/execute.html
Expand Down
4 changes: 4 additions & 0 deletions tutorials/_static/marbletutorial.css
View file
Open in desktop
Copy link
Collaborator

@mishaschwartz mishaschwartz Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't this this is necessary and these attributes are overridden by other css:

  • height is unset for the logo_img class which overrides this setting
  • max-width is set to 100% and the parent of this element never gets larger than about 230px so the width you're setting here is basically ignored.

What are you trying to achieve here? Maybe there's a better way to do it.

Copy link
Contributor Author

@alexandercyu alexandercyu Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to set the dimensions of the image. I had tested it before by setting it to 100px and it worked. I just assumed the size of the image shown was accurate.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.navbar-brand img{
width: 400px;
height: 200px;
}
21 changes: 21 additions & 0 deletions tutorials/marble-logo-text.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed tutorials/marble.png
View file
Open in desktop
Binary file not shown.